Repository navigation
ci: remove the diffpy.srfit 3.4.0rc0 bridge and require srfit>=3.4.0 - #9
Merged
Merged
Conversation
cadenmyers13
commented
Oct 26, 2026
| numpy | ||
| diffpy.srreal | ||
| diffpy.srfit | ||
| diffpy.srfit>=3.4.0 |
Contributor
Author
There was a problem hiding this comment.
These pins are useful because if someone has a srfit less than 3.4.0 and they change to cmistructure it will not work. having this will autoupdate their srfit
Contributor
Author
|
@sbillinge ready for review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 94.57% 94.57%
=======================================
Files 5 5
Lines 645 645
=======================================
Hits 610 610
Misses 35 35 🚀 New features to boost your workflow:
|
Contributor
|
this makes my heart sing.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
srfit 3.4.0 is on conda-forge, so CI no longer needs to pip install the rc (reverts 2cc4b01). cmistructure calls methods that srfit 3.3.1 lacks, so declare the lower bound in conda.txt and pip.txt.